[Skiboot] [PATCH] hw/p8-i2c: Fix i2c request timeout

Andrew Donnellan andrew.donnellan at au1.ibm.com
Tue Sep 25 16:23:00 AEST 2018


On 20/9/18 3:05 am, Frederic Barrat wrote:
> Commit eb146fac9685 ("core/i2c: Move the timeout field into
> i2c_request") simplified a bit how a request timeout is
> handled. However there's now some confusion between milliseconds and
> timebase increments when defining or using the timeout values, which
> breaks i2c requests made for opencapi, and probably others too.
> 
> This patch declares all the timeout in milliseconds and just converts
> to timebase at the end of the chain, as needed.
> 
> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>

Stewart: would be good if we could get this merged sooner rather than later.


Andrew


-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list