[Skiboot] [PATCH] hdata: Make sure FW feature name is not NULL

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Mon Sep 17 18:43:26 AEST 2018

On 09/13/2018 02:22 PM, Stewart Smith wrote:
> Vaibhav Jain <vaibhav at linux.vnet.ibm.com> writes:
>> Hi Vasant,
>> Bikeshedding a bit but a minor review comment:
>> "hdata: Make sure FW feature name is not NULL"
>> I think it should be "not Empty" rather than "not NULL" since you are
>> checking for length and 'name' and 'feature->name' being a static arrays
>> wont be NULL.
> Fixed the bikeshed when merging.



More information about the Skiboot mailing list