[Skiboot] [PATCH] hdata: Make sure FW feature name is not NULL

Stewart Smith stewart at linux.ibm.com
Thu Sep 13 18:52:15 AEST 2018


Vaibhav Jain <vaibhav at linux.vnet.ibm.com> writes:
> Hi Vasant,
>
> Bikeshedding a bit but a minor review comment:
>
> "hdata: Make sure FW feature name is not NULL"
>
> I think it should be "not Empty" rather than "not NULL" since you are
> checking for length and 'name' and 'feature->name' being a static arrays
> wont be NULL.

Fixed the bikeshed when merging.

Merged to master as of 9d9395c3d542b5b2949b6ba3d5c0a8f1618b77e0
-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list