[Skiboot] [PATCH stable 3/3] hdata/i2c: Skip unknown device type

Pavaman Subramaniyam pavsubra at linux.vnet.ibm.com
Wed Oct 24 01:35:26 AEDT 2018


From: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

commit c94b5a9e9c32724cba92e78073f6e3c334a0ad43 upstream.

Do not add unknown I2C devices to device tree.

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 hdata/i2c.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/hdata/i2c.c b/hdata/i2c.c
index 939ba76..02428fc 100644
--- a/hdata/i2c.c
+++ b/hdata/i2c.c
@@ -322,14 +322,16 @@ int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index,
 		 * outdated or the device is marked as unknown (0xFF) in the
 		 * hdat. Log both cases to see what/where/why.
 		 */
-		if (!type || dev->type == 0xFF)
+		if (!type || dev->type == 0xFF) {
 			prlog(PR_WARNING, "HDAT I2C: found e%dp%d - %s@%x dp:%02x (%#x:%s)\n",
 			      dev->i2cm_engine, dev->i2cm_port, name, dev_addr,
 			      dev->dev_port, purpose, info->label);
-		else
-			prlog(PR_DEBUG, "HDAT I2C: found e%dp%d - %s@%x dp:%02x (%#x:%s)\n",
-			      dev->i2cm_engine, dev->i2cm_port, name, dev_addr,
-			      dev->dev_port, purpose, info->label);
+			continue;
+		}
+
+		prlog(PR_DEBUG, "HDAT I2C: found e%dp%d - %s@%x dp:%02x (%#x:%s)\n",
+		      dev->i2cm_engine, dev->i2cm_port, name, dev_addr,
+		      dev->dev_port, purpose, info->label);
 
 		/*
 		 * Multi-port device require special handling since we need to
-- 
2.4.3



More information about the Skiboot mailing list