[Skiboot] [PATCH 0/4] libflash: Add ipmi-hiomap tests and fixes

Andrew Jeffery andrew at aj.id.au
Wed Nov 7 17:55:48 AEDT 2018


ipmi-hiomap was in desperate need of some tests, and the lack of them meant I
bungled some of the BMC-to-host event handling (again).

This series reworks the libflash/test makefile, adds a couple of tests, makes
the fix to the IPMI hiomap implementation and finally captures the desired
behaviour in a set of additional test cases. The makefile rewrite was done to
make it easier to add tests with full control over what gets linked into each
test binary. It's a little hairy, and a little bit automake-ish, but hopefully
that doesn't put people off of the concept too much.

Patch 4/4 implements the fix for the event handling, and we'll need to backport
it to the stable branches. I've tested it, as has SMC on Boston, and it
definitely helps with correctness/stability. If necessary I can respin it to
drop the test hunks so we can just take the one patch rather than pull in the
test infra/makefile changes as well.

As with the previous series there are a few BMC-side changes that complement
these fixes:


Please test / review!


Andrew Jeffery (4):
  libflash/test: Rewrite Makefile.check to improve scalability
  libflash/ipmi-hiomap: Fix argument type warning on x86-64
  libflash/ipmi-hiomap: Add support for unit tests
  libflash/ipmi-hiomap: Respect daemon presence and flash control

 libflash/ipmi-hiomap.c           |  36 +-
 libflash/ipmi-hiomap.h           |  31 ++
 libflash/test/Makefile.check     | 179 +++++++--
 libflash/test/stubs.c            |  19 +
 libflash/test/stubs.h            |   5 +
 libflash/test/test-ipmi-hiomap.c | 635 +++++++++++++++++++++++++++++++
 6 files changed, 841 insertions(+), 64 deletions(-)
 create mode 100644 libflash/test/test-ipmi-hiomap.c


More information about the Skiboot mailing list