[Skiboot] [PATCH 3/9] ipmi-watchdog: Don't reset the watchdog twice

[Alistair Popple]

On Wednesday, 23 May 2018 5:13:29 PM AEST William A. Kennington III wrote:
> There is no clarification for why this change was needed, but presumably
> this is due to a buggy BMC implementation where the Watchdog Set command

That is correct, although I'm not sure if the buggy BMC implementation
was ever fixed so we should probably test this on a P8 box as well.

- Alistair

> was processed concurrently or after the initial Watchdog Reset. This
> inversion would cause the watchdog to stop since the DONT_STOP bit was
> not set. Since we are now using the DONT_STOP bit during initialization,
> the watchdog should not be stopped even if an inversion occurs.
> 
> Signed-off-by: William A. Kennington III <wak at google.com>
> ---
>  hw/ipmi/ipmi-watchdog.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/ipmi/ipmi-watchdog.c b/hw/ipmi/ipmi-watchdog.c
> index ee1608443..e8efba2b4 100644
> --- a/hw/ipmi/ipmi-watchdog.c
> +++ b/hw/ipmi/ipmi-watchdog.c
> @@ -143,9 +143,5 @@ void ipmi_wdt_init(void)
>  	 * could crash before the wdt has actually been started. */
>  	sync_reset_wdt();
>  
> -	/* For some reason we have to reset it twice to get it to
> -	 * actually start the first time. */
> -	sync_reset_wdt();
> -
>  	return;
>  }
>