[Skiboot] [PATCH 3/9] ipmi-watchdog: Don't reset the watchdog twice

William A. Kennington III wak at google.com
Thu May 24 10:13:29 AEST 2018

There is no clarification for why this change was needed, but presumably
this is due to a buggy BMC implementation where the Watchdog Set command
was processed concurrently or after the initial Watchdog Reset. This
inversion would cause the watchdog to stop since the DONT_STOP bit was
not set. Since we are now using the DONT_STOP bit during initialization,
the watchdog should not be stopped even if an inversion occurs.

Signed-off-by: William A. Kennington III <wak at google.com>
 hw/ipmi/ipmi-watchdog.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/ipmi/ipmi-watchdog.c b/hw/ipmi/ipmi-watchdog.c
index ee1608443..e8efba2b4 100644
--- a/hw/ipmi/ipmi-watchdog.c
+++ b/hw/ipmi/ipmi-watchdog.c
@@ -143,9 +143,5 @@ void ipmi_wdt_init(void)
 	 * could crash before the wdt has actually been started. */
-	/* For some reason we have to reset it twice to get it to
-	 * actually start the first time. */
-	sync_reset_wdt();

More information about the Skiboot mailing list