[Skiboot] [PATCH] hmi: Fix clearing HMER on debug trigger
Michael Neuling
mikey at neuling.org
Wed May 9 07:17:37 AEST 2018
In the recent patch:
eddff9bf40 hmi: Clear unknown debug trigger
I rebased the code from an older skiboot before the HMI rework. When I
did this, I missed the handled flag. Without this the HMER is not
cleared properly and the HMI keeps happening.
This properly sets the handled flag and hence clears the HMER bit.
Signed-off-by: Michael Neuling <mikey at neuling.org>
---
core/hmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/core/hmi.c b/core/hmi.c
index 530371e2b8..3bf20c0aa7 100644
--- a/core/hmi.c
+++ b/core/hmi.c
@@ -1259,6 +1259,7 @@ static int handle_hmi_exception(uint64_t hmer, struct OpalHMIEvent *hmi_evt,
}
}
if (hmer & SPR_HMER_TRIG_FIR_HMI) {
+ handled |= SPR_HMER_TRIG_FIR_HMI;
hmer &= ~SPR_HMER_TRIG_FIR_HMI;
hmi_print_debug("Clearing unknown debug trigger", hmer);
--
2.14.1
More information about the Skiboot
mailing list