[Skiboot] [PATCH v2] phb4: Hardware init updates
stewart at linux.ibm.com
Thu May 3 14:33:29 AEST 2018
Russell Currey <ruscur at russell.cc> writes:
> CFG Write Request Timeout was incorrectly set to informational and not
> fatal for both non-CAPI and CAPI, so set it to fatal. This was a
> mistake in the specification. Correcting this fixes a niche bug in
> escalation (which is necessary on pre-DD2.2) that can cause a checkstop
> due to a NCU timeout.
> In addition, set the values in the timeout control registers to match.
> This fixes an extremely rare and unreproducible bug, though the current
> timings don't make sense since they're higher than the NCU timeout (16)
> which will checkstop the machine anyway.
> Signed-off-by: Russell Currey <ruscur at russell.cc>
> Since v1: Added bit for CAPI too, added timer change
> hw/phb4.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Seems to test okay with the limited testing I can give it, merged to
master as of 411dc0813f24d2b282dbd1ff75b71671b60c7b40
OPAL Architect, IBM.
More information about the Skiboot