[Skiboot] [PATCH v9 0/2] Add SBE driver support
Stewart Smith
stewart at linux.ibm.com
Tue May 1 13:25:01 AEST 2018
Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> This patchset adds support to communicate to SBE.
>
> Patch 1 adds primary property to xscom node. Its used to detect master SBE.
> Patch 2 adds base SBE driver.
>
> Changes in v9:
> - As BenH suggested changed interrupt handler code to process one
> bit at a time.
> - Also added logic in interrupt handler code to detect unhandled
> interrupt bits.
>
> Changes in v8:
> - Addressed Ben's review comments on v7
> - Major onces:
> - Fixex p9_sbe_msg_complete()
> - Removed inline function to update sbe state
> - Fixed interrupt handler code
>
> Changes in v7:
> - Addressed Ben's review comments
> - Major onces :
> Separate response message
> Reoganization of poller and interrupt handler code
> Convert recursion to loop
> Fixing return value issues
>
> Changes in v6:
> - I need base driver support for MPIPL as well. Hence I've split
> base driver and timer support to separate patchset.
> - Reworked base driver code based on Ben's review comment.
> - Using new HDAT property to detect master chip SBE
>
> Changes in v5:
> - Rebased on top of upstream master
> - Synced to latest SBE-Host spec
> - Fixed sbe_sync_msg()
> - Removed continous timer call
>
> Changes in v4:
> - Used PNOR info idata pointer to find primary chip
> - Fixed few return value issues
>
> Testing:
> - Tested this patchset on P9 system and it working fine.
>
> Vasant Hegde (2):
> hdata: Add 'primary' property to master chip xscom node
> Add SBE driver support
>
> core/init.c | 7 +
> hdata/spira.c | 5 +-
> hdata/spira.h | 1 +
> hw/psi.c | 2 +-
> hw/sbe-p9.c | 696 +++++++++++++++++++++++++++++++++++++++++++++++++++++--
> include/chip.h | 4 +
> include/sbe-p9.h | 206 +++++++++++++++-
> 7 files changed, 898 insertions(+), 23 deletions(-)
Thanks! Series merged to master as of
6739c890a2f298ed382b9557840a493fb97df44b.
If there's any more benh thoughts, should be safe to bring in after
6.0-rc1 (which I'm looking at tagging today)
--
Stewart Smith
OPAL Architect, IBM.
More information about the Skiboot
mailing list