[Skiboot] [PATCH] uart: fix uart_opal_flush to take console lock over uart_con_flush

[Stewart Smith]

Nicholas Piggin <npiggin at gmail.com> writes:
> On Mon, 30 Apr 2018 17:42:20 +1000
> Stewart Smith <stewart at linux.ibm.com> wrote:
>
>> Nicholas Piggin <npiggin at gmail.com> writes:
>> > Cc: Russell Currey <ruscur at russell.cc>
>> > Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
>> > ---
>> >  hw/lpc-uart.c | 10 ++++++++--
>> >  1 file changed, 8 insertions(+), 2 deletions(-)  
>> 
>> Whoops! Merged to master as of 23dc884f8a0f0b52d3e9312b64b9b02fcd8453a1.
>> 
>> I'm kinda going umm-ahh on if should pick back to any stable
>> branch. Maybe? Have we seen an actual problem because of it? Will we?
>> 
>
> Yeah it would be good if we can. We haven't seen a problem but Linux
> rarely uses the call at the moment. I'd like to start using it more,
> but I don't know how advisable that would be for the foreseeable
> future :(

We could always create a FLUSH2 call which is "flush, but with the
locking bug fixed" and that way Linux could know that it's not going to
be buggy and miss the lock.

-- 
Stewart Smith
OPAL Architect, IBM.