[Skiboot] [PATCH v2 1/2] vpd: Sanitize VPD data

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Jun 28 15:56:37 AEST 2018


On 06/28/2018 09:32 AM, Stewart Smith wrote:
> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>> On OpenPower system, VPD keyword size tells us the maximum size of the data.
>> But they fill trailing end with space (0x20) instead of NULL. Also spec
>> doesn't stop user to have space (0x20) within actual data.
>>
>> This patch discards trailing spaces before populating device tree.
>>
>> Reported-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> 
> Thanks, series merged to master as of
> 861350941f9a3fb76ebcae3e5a32b3cbec929d03
> (with a make check fix)

Thanks for fixing make check.

I totally forgot to add stable # 6.0+ to this patchset. This should go to stable 
branch.

Can you please put this in stable branch as well?

-Vasant




More information about the Skiboot mailing list