[Skiboot] [PATCH v2] hw/npu2, core/hmi: Use NPU instead of NPU2 as log message prefix

Stewart Smith stewart at linux.ibm.com
Thu Jun 28 14:02:25 AEST 2018


Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
> The NPU2{DBG,INF,ERR} macros use "NPU%d" as a prefix to identify messages
> relating to a particular NPU.
>
> It's slightly confusing to have per-NPU messages prefixed with "NPU0" or
> "NPU1" and NPU-generic messages prefixed with "NPU2". On some future system
> we could potentially have a NPU #2 in which case it'd be really confusing.
>
> Use NPU rather than NPU2 for NPU-generic log messages. There's no risk of
> confusion with the original npu.c code since that's only for P8.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> Acked-by: Reza Arbab <arbab at linux.ibm.com>
>
> ---
>
> v1->v2:
>
>  - Change messages in core/hmi.c as well (thanks Reza)
> ---
>  core/hmi.c |  6 +++---
>  hw/npu2.c  | 16 ++++++++--------
>  2 files changed, 11 insertions(+), 11 deletions(-)

thanks, merged to master as of 44709b88491c63d75febc5f4859a0b1a580a9232
-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list