[Skiboot] [PATCH] trival: Remove an extra reg read of VUART1_GCTRLA

Balbir singh bsingharora at gmail.com
Thu Jun 7 23:29:03 AEST 2018

The comments did not say if the read was needed to
ensure the previous write completed, but otherwise
the read is followed by a read of VUART1_GCTRLB and the
value of v is discarded.

Signed-off-by: Balbir singh <bsingharora at gmail.com>

NOTE: As you might suspect I have no way of testing this
except for compile testing it

 hw/ast-bmc/ast-io.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/ast-bmc/ast-io.c b/hw/ast-bmc/ast-io.c
index 1e826fcc..a07f5822 100644
--- a/hw/ast-bmc/ast-io.c
+++ b/hw/ast-bmc/ast-io.c
@@ -434,7 +434,6 @@ void ast_setup_vuart1(uint16_t io_base, uint8_t irq)
 	v = bmc_sio_ahb_readl(VUART1_GCTRLA);
 	v = v & ~2u;
 	bmc_sio_ahb_writel(v, VUART1_GCTRLA);
-	v = bmc_sio_ahb_readl(VUART1_GCTRLA);
 	/* IRQ number */
 	v = bmc_sio_ahb_readl(VUART1_GCTRLB);

More information about the Skiboot mailing list