[Skiboot] [PATCH] npu2-opencapi: reduce number of retries to train the link

Andrew Donnellan andrew.donnellan at au1.ibm.com
Wed Jun 6 10:30:31 AEST 2018


On 05/06/18 20:27, Frederic Barrat wrote:
> We've been reliably training the opencapi link on the first attempt
> for quite a while. Furthermore, if it doesn't train on the first
> attempt, retries haven't been that useful. So let's reduce the number
> of attempts we do to train the link.
> 
> 2 retries = 3 attempts to train.
> 
> Each (failed) training sequence costs about 3 seconds.
> 
> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>

Acked-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

> ---
>   hw/npu2-opencapi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/npu2-opencapi.c b/hw/npu2-opencapi.c
> index 3465d70c..d085cd15 100644
> --- a/hw/npu2-opencapi.c
> +++ b/hw/npu2-opencapi.c
> @@ -78,7 +78,7 @@
>   #define   OCAPI_SLOT_FRESET_DEASSERT_DELAY  (OCAPI_SLOT_FRESET + 4)
>   #define   OCAPI_SLOT_FRESET_INIT_DELAY      (OCAPI_SLOT_FRESET + 5)
>   
> -#define OCAPI_LINK_TRAINING_RETRIES	5
> +#define OCAPI_LINK_TRAINING_RETRIES	2
>   #define OCAPI_LINK_TRAINING_TIMEOUT	3000 /* ms */
>   #define OCAPI_LINK_STATE_TRAINED        0x7
>   
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list