[Skiboot] [PATCH] opal/hmi: Display correct chip id while printing NPU FIRs.

Balbir Singh bsingharora at gmail.com
Sat Jun 2 01:24:41 AEST 2018

On Thu, May 31, 2018 at 6:34 PM, Mahesh J Salgaonkar
<mahesh at linux.vnet.ibm.com> wrote:
> From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> HMIs for NPU xstops are broadcasted to all chips. All cores on all the
> chips receive HMI. HMI handler correctly identifies and extracts the
> NPU FIR details from affected chip, but while printing FIR data it
> prints chip id and location code details of this_cpu()->chip_id which
> may not be correct. This patch fixes this issue.

The core does not matter here, does it? It's the NPU, it's one per
If fir, mask and action match, this_cpu()->chip_id's location code
should be correct.
Am I missing something? Have you seen examples of this printing the wrong thing
or did you catch this via code-review?


More information about the Skiboot mailing list