[Skiboot] [PATCH 1/3] hw/phb4: Print the PEs in the EEH dump in hex

Stewart Smith stewart at linux.ibm.com
Thu Jul 26 19:00:05 AEST 2018


"Oliver O'Halloran" <oohall at gmail.com> writes:
> Linux always displays the PE number in hexidecimal while skiboot
> displays the PEST index (PE number) in decimal. This makes correlating
> errors between Skiboot and Linux more annoying than it should be so
> this patch makes Skiboot print the PEST number in hex.
>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>  hw/phb4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/phb4.c b/hw/phb4.c
> index 0478d2dab341..ff0f3f5ad5b2 100644
> --- a/hw/phb4.c
> +++ b/hw/phb4.c
> @@ -2048,7 +2048,7 @@ static void phb4_eeh_dump_regs(struct phb4 *p)
>  	for (i = 0; i < OPAL_PHB4_NUM_PEST_REGS; i++) {
>  		if (!s->pestA[i] && !s->pestB[i])
>  			continue;
> -		PHBERR(p, "               PEST[%03d] = %016llx %016llx\n",
> +		PHBERR(p, "               PEST[%03x] = %016llx
> %016llx\n",

Although now that I think about it, perhaps having 0x as a prefix there
would be helpful, but I guess you're only reading this if you're already
in the poo and can probably check your skiboot source.

Series merged to master as of 3e23604be0cbff4919cd1d99369483f9817f8c76

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list