[Skiboot] [PATCH 3/3] device-tree vpd/xscom@: add more VPD to xscom@ nodes

[Stewart Smith]

Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com> writes:
> On Tue, Apr 10, 2018 at 02:25:24PM +1000, Stewart Smith wrote:
>> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>> > On 04/06/2018 10:46 AM, Stewart Smith wrote:
>> >> From: Stewart Smith <stewart at linux.vnet.ibm.com>
>> 
>> >> part-number      "02AA863"
>> >> vendor           "IBM             "
>> >> 
>> >> This change will also affect what we put in the /vpd hierarchy,
>> >> but by making it more complete.
>> >
>> > AFAIK VINI, VRML and OPFR are mutually exclusive. We should expect either one of 
>> > these type VPD not mixed one (Of course in some system we are getting mixed 
>> > one). IMO that's bug in hostboot side of fix.
>> 
>> yeah, we're certainly getting things mixed together in the VPD blobs
>> that we export in the DT at least. I'm not sure where Hostboot picks
>> these up from though and if we're really just getting a few things
>> mashed together.
>> 
>> Oliver/Ananth, by any chance do you know?
>
> AFAIR, all the OP* keyword VPD was added exclusively for OP boxes, but
> whether or not the older keywords continue to exist with them was
> unclear at the time. I am checking with the FW folks... will update
> with findings...

Any findings?

I have to admit I haven't gone back and looked at this closely either,
but maybe I should :)

-- 
Stewart Smith
OPAL Architect, IBM.