[Skiboot] [PATCH v2 5/9] npu2-opencapi: Configure NPU for OpenCAPI
Frederic Barrat
fbarrat at linux.vnet.ibm.com
Fri Jan 26 05:33:10 AEDT 2018
> diff --git a/include/npu2-regs.h b/include/npu2-regs.h
> index b6dae7b..7e3431d 100644
> --- a/include/npu2-regs.h
> +++ b/include/npu2-regs.h
[ snip ]
> @@ -362,6 +420,8 @@ void npu2_scom_write(uint64_t gcid, uint64_t scom_base,
> #define NPU2_MISC_IRQ_LOG13 NPU2_REG_OFFSET(NPU2_STACK_MISC, NPU2_BLOCK_MISC, 0x368)
> #define NPU2_MISC_IRQ_LOG14 NPU2_REG_OFFSET(NPU2_STACK_MISC, NPU2_BLOCK_MISC, 0x370)
> #define NPU2_MISC_IRQ_LOG15 NPU2_REG_OFFSET(NPU2_STACK_MISC, NPU2_BLOCK_MISC, 0x378)
> +#define NPU2_MISC_IRQ_ON_ERROR_EN_FIR2 NPU2_REG_OFFSET(NPU2_STACK_MISC, NPU2_BLOCK_MISC, 0x408)
For consistency if nothing else, it should be named:
NPU2_MISC_IRQ_ENABLE2
(See a few lines above for the matching FIR 0&1 registers, which already
existed)
Similarly, patch 7, about link training, introduces
NPU2_MISC_FENCE_ON_ERROR_EN_FIR2, which should be renamed
NPU2_MISC_FENCE_ENABLE2 (though we don't seem to be using it??)
Apologies if I was the one misnaming them at first...
Fred
More information about the Skiboot
mailing list