[Skiboot] [PATCH v4] power-mgmt : occ : Add 'freq-domain-indicator' DT property

Abhishek huntbag at linux.vnet.ibm.com
Mon Jan 22 19:28:00 AEDT 2018


On 01/02/2018 11:19 AM, Vasant Hegde wrote:
> On 12/20/2017 11:57 AM, Abhishek Goel wrote:
>> Add a new device-tree property freq-domain-indicator to define group of
>> CPUs which would share same frequency. This property has been added 
>> under
>> power-mgmt node.
>>
>>
>
> .../...
>
>>
>> @@ -660,6 +664,13 @@ static bool add_cpu_pstate_properties(int 
>> *pstate_nom)
>>           return false;
>>       }
>>
>> +    if (proc_gen == proc_gen_p8)
>> +        freq_domain_indicator = P8_PIR_CORE_MASK;
>> +    else if (proc_gen == proc_gen_p9)
>> +        freq_domain_indicator = P9_PIR_QUAD_MASK;
>> +    else
>> +        prerror("OCC: freq-domain-indicator: Processor is not 
>> supported\n");
>> +
>>       /* Add the device-tree entries */
>>       dt_add_property(power_mgt, "ibm,pstate-ids", dt_id,
>>               nr_pstates * sizeof(u32));
>> @@ -669,6 +680,13 @@ static bool add_cpu_pstate_properties(int 
>> *pstate_nom)
>>       dt_add_property_cells(power_mgt, "ibm,pstate-nominal", pnom);
>>       dt_add_property_cells(power_mgt, "ibm,pstate-max", pmax);
>>
>> +    if (freq_domain_indicator) {
>> +        dt_add_property_cells(power_mgt, "ibm,freq-domain-indicator",
>> +                        freq_domain_indicator);
>> +        dt_add_property_strings(power_mgt, "compatible",
>> +                    "freq-domain-v1", "P9-occ-quirk");
>
> Why are you adding "P9-occ-quirk" here?
>
>
> -Vasant
Have posted the next version with the additional documentation for the same.
Also the kernel patch which will use this DT changes is  posted here :
https://patchwork.kernel.org/patch/10177461/

-Abhishek



More information about the Skiboot mailing list