[Skiboot] [PATCH] libstb/cvc: Register P8 secure ROM code correctly

Stewart Smith stewart at linux.vnet.ibm.com
Fri Jan 19 13:47:06 AEDT 2018


Register the location of the secure ROM, not the address of the location.

Fixes: 594c7a6ae3ccc
Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 libstb/cvc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libstb/cvc.c b/libstb/cvc.c
index e9df190514d1..d46617b29070 100644
--- a/libstb/cvc.c
+++ b/libstb/cvc.c
@@ -214,8 +214,8 @@ static int cvc_secure_rom_init(void) {
 	xscom_read(chip->id, reg_addr, &reg_data);
 	memcpy_from_ci(secure_rom_mem, (void*) reg_data,
 		       SECURE_ROM_MEMORY_SIZE);
-	cvc_register((uint64_t)&secure_rom_mem,
-		     (uint64_t)&secure_rom_mem + SECURE_ROM_MEMORY_SIZE-1);
+	cvc_register((uint64_t)secure_rom_mem,
+		     (uint64_t)secure_rom_mem + SECURE_ROM_MEMORY_SIZE-1);
 	cvc_service_register(CVC_SHA512_SERVICE, SECURE_ROM_SHA512_OFFSET, 1);
 	cvc_service_register(CVC_VERIFY_SERVICE, SECURE_ROM_VERIFY_OFFSET, 1);
 	return 0;
-- 
2.14.3



More information about the Skiboot mailing list