[Skiboot] [PATCH 1/2] core: Avoid possible uninitialized pointer read (CID 209502)

Nicholas Piggin npiggin at gmail.com
Tue Jan 16 00:34:11 AEDT 2018


On Mon, 15 Jan 2018 16:17:59 +1100
Cyril Bur <cyril.bur at au1.ibm.com> wrote:

> A likely copy and paste oversight.
> 
> Fixes: 0d84ea6b (core: Add support for quiescing OPAL)
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>

Reviewed-by: Nicholas Piggin <npiggin at gmail.com>

> ---
>  core/opal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/core/opal.c b/core/opal.c
> index 1bca774c..e862b4c6 100644
> --- a/core/opal.c
> +++ b/core/opal.c
> @@ -283,7 +283,7 @@ int64_t opal_quiesce(uint32_t quiesce_type, int32_t cpu_target)
>  	if (target) {
>  		while (target->in_opal_call) {
>  			if (tb_compare(mftb(), end) == TB_AAFTERB) {
> -				printf("OPAL quiesce CPU:%04x stuck in OPAL\n", c->pir);
> +				printf("OPAL quiesce CPU:%04x stuck in OPAL\n", target->pir);
>  				stuck = true;
>  				break;
>  			}



More information about the Skiboot mailing list