[Skiboot] [PATCH v2] Witherspoon: Remove old Witherspoon platform definition

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jan 15 17:39:32 AEDT 2018


Alistair Popple <alistair at popple.id.au> writes:
> An old Witherspoon platform definition was added to aid the transition from
> versions of Hostboot which didn't have the correct NVLink HDAT information
> available and/or planar VPD. These system should now be updated so remove
> the possibly incorrect default assumption.
>
> This may disable NVLink on old out-dated systems but it can easily be
> restored with the appropriate FW and/or VPD updates. In any case there is a
> a 50% chance the existing default behaviour was incorrect as it only
> supports 6 GPU systems. Using an incorrect platform definition leads to
> undefined behaviour which is more difficult to detect/debug than not
> creating the NVLink devices so remove the possibly incorrect default
> behaviour.
>
> Signed-off-by: Alistair Popple <alistair at popple.id.au>
> ---
>
> Changes from v1:
>
>  - Remove checks for NPU node and PCIe slot information in
>    witherspoon_probe()

Merged to master as of 6f8c49b0bac4975aceef96e2f11c70bdf75c284e
-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list