[Skiboot] [PATCH 9/9] platforms: Add OpenCAPI platform data and device tree nodes

[Andrew Donnellan]

On 12/01/18 02:08, Frederic Barrat wrote:
>> +static void zaius_create_npu(void)
>> +{
>> +    struct dt_node *xscom, *npu;
>> +    int npu_index = 0;
>> +    int phb_index = 7;
>> +    char namebuf[32];
>> +    prlog(PR_DEBUG, "OCAPI: Adding NPU device nodes\n");
>> +    dt_for_each_compatible(dt_root, xscom, "ibm,xscom") {
>> +        snprintf(namebuf, sizeof(namebuf), "npu@%x", NPU_BASE);
>> +        npu = dt_new(xscom, namebuf);
> 
> 
> Maybe we should test for its existence before adding it, to prepare for 
> when it will be added by hostboot/HDAT. If not, running an old skiboot 
> on a newer hostboot will lead to... I'm not sure what, but likely 
> nothing good.
> 
> Same applies for the i2c port below.

ACK

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited