[Skiboot] [PATCH 7/9] npu2-opencapi: Train OpenCAPI links and setup devices

Andrew Donnellan andrew.donnellan at au1.ibm.com
Fri Jan 12 13:53:30 AEDT 2018


On 12/01/18 01:42, Frederic Barrat wrote:
>> +    dt_for_each_compatible(dt_root, dn, "ibm,power9-i2c-port") {
>> +        if (streq(port_name, dt_prop_get(dn, "ibm,port-name"))) {
>> +            opal_id = dt_prop_get_u32(dn, "ibm,opal-id");
>> +            break;
>> +        }
>> +    }
> 
> 
> I'm just realizing now that it's a bit silly to always parse the device 
> tree on each reset. The opal_id value is per-chip, I believe, so we 
> don't really have a proper place to store it, but maybe we could store 
> it per-device?

Good point.

It occurs to me that we didn't test this on a machine with an OBUS3 - 
presumably there's going to be a second port for that OBUS...

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list