[Skiboot] [PATCH 3/9] platform: Add fields for OpenCAPI platform data
Andrew Donnellan
andrew.donnellan at au1.ibm.com
Thu Jan 11 16:48:22 AEDT 2018
On 11/01/18 14:01, Andrew Donnellan wrote:
>> Not convinced that voltage setting is going to be useful. We'll find
>> out soon enough on witherspoon, I guess. We could remove it for now if
>> we assume we'll need another patchset for witherspoon (which seems
>> likely to me, at least for the platform code).
>
> Yeah, it's likely we'll need another patch for witherspoon after this...
> Ideally this should be set correctly by hostboot, we should check that.
Flashed our witherspoon with a current op-build pnor, it doesn't appear
to set the bit correctly. Hmm.
>
>>
>>> + uint8_t i2c_engine; /* I2C engine number */
>>> + uint8_t i2c_port; /* I2C port number */
>>> + uint32_t i2c_offset[3]; /* Offsets on I2C device */
>>> + uint8_t i2c_odl0_data[3]; /* Data to reset ODL0 */
>>> + uint8_t i2c_odl1_data[3]; /* Data to reset ODL1 */ > +
>>> uint8_t i2c_odl01_data[3]; /* Data to reset both ODL0 and ODL1 */
>>
>> I know I'm at the origin of this, but I don't think we reset the 2
>> links simultaneously any more, so it could be dropped.
>>
>
> Will drop.
>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com IBM Australia Limited
More information about the Skiboot
mailing list