[Skiboot] [PATCH 2/6] npu2: Split device index into brick and link index

Alistair Popple alistair at popple.id.au
Tue Aug 21 15:58:56 AEST 2018

On Monday, 20 August 2018 11:13:36 AM AEST Reza Arbab wrote:
> On Fri, Aug 17, 2018 at 06:44:37PM +1000, Andrew Donnellan wrote:
> >On Witherspoon, OpenCAPI devices attached to link indexes 0 and 1 are
> >handled by bricks 2 and 3.
> >
> >Rename index to brick_index, and add a new field, link_index, to
> >refer to the link index. For now, we set those values identically.
> Weird. Instead of a whole new field, could this be done with some kind 
> of new "index_to_whatever(index)" macro or function instead?

Well in theory at least a particular NPU brick can connect to different OBUS
links depending on the configuration of some HW MUXes so that might require
changing a macro. No idea if we will ever need to support HW with different MUX
settings than default though.

Reviewed-By: Alistair Popple <alistair at popple.id.au>

> Not a big deal, though;
> Acked-by: Reza Arbab <arbab at linux.ibm.com>

More information about the Skiboot mailing list