[Skiboot] [PATCH 2/6] npu2: Split device index into brick and link index
andrew.donnellan at au1.ibm.com
Tue Aug 21 11:49:29 AEST 2018
On 21/08/18 02:13, Reza Arbab wrote:
> On Fri, Aug 17, 2018 at 06:44:37PM +1000, Andrew Donnellan wrote:
>> On Witherspoon, OpenCAPI devices attached to link indexes 0 and 1 are
>> handled by bricks 2 and 3.
>> Rename index to brick_index, and add a new field, link_index, to
>> refer to the link index. For now, we set those values identically.
> Weird. Instead of a whole new field, could this be done with some kind
> of new "index_to_whatever(index)" macro or function instead?
> Not a big deal, though;
> Acked-by: Reza Arbab <arbab at linux.ibm.com>
Yeah I went back and forth on this more than a few times.
I think I prefer it this way for the sake of clarity - the term "index"
is rather overloaded as is.
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com IBM Australia Limited
More information about the Skiboot