[Skiboot] [PATCH] hw/npu2: Don't assert if we hit a mixed OpenCAPI/NVLink setup

Andrew Donnellan andrew.donnellan at au1.ibm.com
Tue Aug 7 13:02:40 AEST 2018


On 07/08/18 13:00, Stewart Smith wrote:
> Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
>> If our device tree contains a mix of OpenCAPI and NVLink links, that's a
>> problem, but it's not fatal and we should simply abort NPU init rather than
>> kill the machine - this is helpful for doing further debugging.
>>
>> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> 
> Merged to master as of 8a8cc857fa3f4a635cd9ef4acbd5abdfbe7872bd
> 
>>
>> Debating whether or not to send a backport of this to the 6.0 stable
>> tree...
> 
> Is it something that could/would occur on any system that someone has
> shipped? Probably not, so we're likely okay?

Yeah, actually they should never hit this in a release - the only case 
where we're seeing this is when skiboot-level platform hacks conflict 
with changes in HDAT, so I don't think we need a stable backport.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list