[Skiboot] [PATCH 4/4] phb4: Use the return value of phb4_fenced() in phb4_get_diag_data()

Stewart Smith stewart at linux.ibm.com
Tue Aug 7 12:57:51 AEST 2018

Cyril Bur <cyril.bur at au1.ibm.com> writes:
> phb4_get_diag_data() checks the flags for the PHB4_AIB_FENCED after
> having called phb4_fenced(). This information is returned by
> phb4_fenced().
> This patch was prompted by an unused return value warning in Coverity.
> Fixes: CID 163734
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> ---
> Fair warning, I know nothing about PCI. This patch just seems to make
> sense. It might be perfectly valid that we should tell Coverity that
> this is done on purpose and to go away.

So, Cyril's address here is going to bounce, but I poked Russell to
confirm that this looked okay, so I merged it as of
0d96d56298d5a918f60babbf5ae26a8a74e8183d and now we get to find out how
wrong we all were :)

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list