[Skiboot] [PATCH 6/6] phb4: Retrain link if degraded

Stewart Smith stewart at linux.vnet.ibm.com
Wed Sep 13 17:09:42 AEST 2017


Michael Neuling <mikey at neuling.org> writes:
> Oops, that's wrong... Major should be 1.  ie.
>
> diff --git a/hw/phb4.c b/hw/phb4.c
> index a3bde18756..c6bb6292ab 100644
> --- a/hw/phb4.c
> +++ b/hw/phb4.c
> @@ -2408,7 +2408,7 @@ static bool phb4_chip_retry_workaround(void)
>  	 */
>  	pvr = mfspr(SPR_PVR);
>  	if (pvr & PVR_POWER9_CUMULUS) {
> -		if ((PVR_VERS_MAJ(pvr) == 2) && (PVR_VERS_MIN(pvr) == 0))
> +		if ((PVR_VERS_MAJ(pvr) == 1) && (PVR_VERS_MIN(pvr) == 0))
>  			return true;
>  	} else { /* NIMBUS */
>  		if (PVR_VERS_MAJ(pvr) == 1)

With this fixup, series merged to master as of
3f936bae970e8ce116151b7106bf7d6437046c19

(now to just shepherd this into all the various places)

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list