[Skiboot] [PATCH 6/6] phb4: Retrain link if degraded

Michael Neuling mikey at neuling.org
Tue Sep 12 16:28:28 AEST 2017


> +	/* Chips that need this retry are:
> +	 *  - CUMULUS DD1.0
> +	 *  - NIMBUS DD2.0 and below
> +	 */
> +	pvr = mfspr(SPR_PVR);
> +	if (pvr & PVR_POWER9_CUMULUS) {
> +		if ((PVR_VERS_MAJ(pvr) == 2) && (PVR_VERS_MIN(pvr) == 0))
> +			return true;

Oops, that's wrong... Major should be 1.  ie.

diff --git a/hw/phb4.c b/hw/phb4.c
index a3bde18756..c6bb6292ab 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -2408,7 +2408,7 @@ static bool phb4_chip_retry_workaround(void)
 	 */
 	pvr = mfspr(SPR_PVR);
 	if (pvr & PVR_POWER9_CUMULUS) {
-		if ((PVR_VERS_MAJ(pvr) == 2) && (PVR_VERS_MIN(pvr) == 0))
+		if ((PVR_VERS_MAJ(pvr) == 1) && (PVR_VERS_MIN(pvr) == 0))
 			return true;
 	} else { /* NIMBUS */
 		if (PVR_VERS_MAJ(pvr) == 1)








More information about the Skiboot mailing list