[Skiboot] [PATCH 2/2] core/hmi: Do not call find_core_checkstop_reason() unconditionally

Balbir Singh bsingharora at gmail.com
Thu Nov 30 23:50:51 AEDT 2017


We tend to call find_core_checkstop_reason() even if the NPU/NX/CAPI
HMI handling paths found and accepted the reason for the local checkstop.
We also trash hmi_evt in the call.

Signed-off-by: Balbir Singh <bsingharora at gmail.com>
---
 core/hmi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/core/hmi.c b/core/hmi.c
index bb144512..62a916ba 100644
--- a/core/hmi.c
+++ b/core/hmi.c
@@ -697,7 +697,8 @@ static void decode_malfunction(struct OpalHMIEvent *hmi_evt)
 		}
 	}
 
-	find_core_checkstop_reason(hmi_evt, &event_generated);
+	if (!event_generated)
+		find_core_checkstop_reason(hmi_evt, &event_generated);
 
 	/*
 	 * If we fail to find checkstop reason, send an unknown HMI event.
-- 
2.13.6



More information about the Skiboot mailing list