[Skiboot] [PATCH v2] prd: Enable error logging via firmware_request interface

[Vasant Hegde]

On 10/17/2017 01:11 PM, Jeremy Kerr wrote:
> Hi Vasant,
>
>> In P9 HBRT sends error logs to FSP via firmware_request interface.
>> This patch adds support to parse error log and send it to FSP.
>
> Looks good to me. One comment though:
>
>> diff --git a/include/prd-fw-msg.h b/include/prd-fw-msg.h
>> index c00405d..19f355a 100644
>> --- a/include/prd-fw-msg.h
>> +++ b/include/prd-fw-msg.h
>> @@ -26,10 +26,24 @@
>>  enum {
>>  	PRD_FW_MSG_TYPE_REQ_NOP = 0,
>>  	PRD_FW_MSG_TYPE_RESP_NOP = 1,
>> +	PRD_FW_MSG_TYPE_RESP_GENERIC = 2,
>> +	PRD_FW_MSG_TYPE_REQ_HCODE_UPDATE = 3,
>> +	PRD_FW_MSG_TYPE_HBRT_FSP = 4,
>> +	PRD_FW_MSG_TYPE_ERROR_LOG = 5,
>>  };
>>
>>  struct prd_fw_msg {
>>  	__be64		type;
>> +	union {
>> +		struct {
>> +			__be64	status;
>> +		} generic_resp;
>> +		struct {
>> +			__be32	plid;
>> +			__be32	size;
>> +			char	data[];
>> +		} __packed errorlog;
>> +	};
>>  };
>>
>>  #define PRD_FW_MSG_BASE_SIZE	sizeof(__be64)
>
> - would it make sense to add the generic_resp (and TYPE_GENERIC_RESP) as
> a separate change? it's not really specific to the error log
> implementation here.

Yeah. May be it makes sense to split the patch.  Let me send v3.

-Vasant