[Skiboot] [PATCH] sensors: occ: Skip counter type of sensors
oohall at gmail.com
Fri Nov 24 15:43:13 AEDT 2017
On Mon, Oct 23, 2017 at 12:39 PM, Stewart Smith
<stewart at linux.vnet.ibm.com> wrote:
> Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com> writes:
>> Don't add counter type of sensors to device-tree as they don't
>> fit into hwmon sensor interface.
> Shouldn't we expose these in the device tree somehow anyway? even if we
> don't currently have a good way to read it from kernel?
How useful to the end user is this information though? If you're
getting voltage droops at the quad or core level it points to either a
system level power distribution issue or the OCC doing a poor job of
managing frequency scaling. This is useful information for developers
rather than system administrators and there are already interfaces
for developers to extract this information. We already filter out OCC
sensors that don't fit into the standard voltage/current/thermal/power
sensor types that hwmon supports so I don't see why we should keep
> I'd prefer we add something in skiboot now so we can get kernel patches
> out later rather than be stuck with not being able to read these sensors
> at all for the first rounds of machines.
Why not just wait until the kernel has a better interface for this
type of sensor? It's not critical and odds are the device-tree
bindings will be different anyway. Trying to shoe-horn it into the
voltage sensor interface just seems like a mistake.
Not just randomly necroposting. I dug up this patch since it was
referenced in BZ159862 and I think you should merge it ;)
> Stewart Smith
> OPAL Architect, IBM.
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
More information about the Skiboot