[Skiboot] [PATCH v2 1/2] npu2: Print bdfn in NPU2DEV* logging macros

Balbir Singh bsingharora at gmail.com
Wed Nov 22 23:57:01 AEDT 2017


On Wed, Nov 22, 2017 at 10:42 AM, Reza Arbab <arbab at linux.vnet.ibm.com> wrote:
> Revise the NPU2DEV{DBG,INF,ERR} logging macros to include the device's
> bdfn. It's useful to know exactly which link we're referring to.
>
> For instance, instead of
>   [  234.044921238,6] NPU6: Starting procedure reset_ntl
>   [  234.048578101,6] NPU6: Starting procedure reset_ntl
>   [  234.051049676,6] NPU6: Starting procedure reset_ntl
>   [  234.053503542,6] NPU6: Starting procedure reset_ntl
>   [  234.057182864,6] NPU6: Starting procedure reset_ntl
>   [  234.059666137,6] NPU6: Starting procedure reset_ntl
>
> we'll get
>   [  234.044921238,6] NPU6:0:0.0 Starting procedure reset_ntl
>   [  234.048578101,6] NPU6:0:0.1 Starting procedure reset_ntl
>   [  234.051049676,6] NPU6:0:0.2 Starting procedure reset_ntl
>   [  234.053503542,6] NPU6:0:1.0 Starting procedure reset_ntl
>   [  234.057182864,6] NPU6:0:1.1 Starting procedure reset_ntl
>   [  234.059666137,6] NPU6:0:1.2 Starting procedure reset_ntl
>
> Signed-off-by: Reza Arbab <arbab at linux.vnet.ibm.com>
> ---

Much nicer

Acked-by: Balbir Singh <bsingharora at gmail.com>


More information about the Skiboot mailing list