[Skiboot] [PATCH v2 2/2] npu2: hw-procedures: Add check_credits procedure

Stewart Smith stewart at linux.vnet.ibm.com
Wed Nov 22 14:40:54 AEDT 2017


Reza Arbab <arbab at linux.vnet.ibm.com> writes:
> Well, the higher layer in this scenario is a third-party binary kernel 
> module, and we want to accomodate existing versions of the driver which 
> don't handle this class of error yet.
>
> It's basically a choice between failing loudly with a clear reason at 
> boot, or crashing in vague ways at runtime when traffic first passes the 
> link. We're finding out that the latter is much harder to diagnose.
>
> I'll spin a v3 which hopefully makes this more clear in the change
> log.

So, I should probably pull mail before merging, but make that v3 a patch
on the v2 as I merged it already :)

Arguably blowing up whenever there's a binary kernel driver is a good
thing to do anyway :), but some people juggle geese, so I guess each to
their own pain.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list