[Skiboot] [PATCH] make_version: Fix check for '.version' file

Stewart Smith stewart at linux.vnet.ibm.com
Wed Nov 22 14:35:37 AEDT 2017


Vaibhav Jain <vaibhav at linux.vnet.ibm.com> writes:
> When building from the non-git tree and with '.version' file missing,
> make_version shows this bash error message.
>
> % make
> ...
> cat: .version: No such file or directory
> ...
> error You need to set SKIBOOT_VERSION environment variable
>
> This patch fixes this issue by updating '.version' file check in
> make_version script to test if it exists as a regular file and is
> of non-zero size.
>
> Fixes: 6a3cad272e4c("Add fallback to .version if not git and no SKIBOOT_VERSION")
> Signed-off-by: Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
> ---
>  make_version.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, merged to master as of 646dbfbec2870f81297e6a01da3f47712068364a

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list