[Skiboot] [PATCH] external/pflash: Fix erasing within a single erase block

Stewart Smith stewart at linux.vnet.ibm.com
Wed Nov 22 07:43:34 AEDT 2017

Cyril Bur <cyril.bur at au1.ibm.com> writes:
> It is possible to erase within a single erase block. Currently the
> pflash code assumes that if the erase starts part way into an erase
> block it is because it needs to be aligned up to the boundary with the
> next erase block.
> Doing an erase smaller than a single erase block will cause underflows
> and looping forever on erase.
> Fixes: ae6cb86c2 ("external/pflash: Reinstate the progress bars")
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> ---
> Side note, this bug is only possible on 64K erase granule platforms.
> Also, this bug cannot be caught by our test suite as it stands because
> the test suite tests with the file backend to blocklevel and it has an
> erase granule of one. I'll have a think about perhaps adding changes so
> that we might be able to catch this.

Hrm..... Something we could perhaps try to test with op-test in the

Merged to master as of ba540e0be90f1055fd9d40b0a6858f96aff6b180
Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list