[Skiboot] [PATCH 3/4] npu2: Remove side effects in assert() calls.

Stewart Smith stewart at linux.vnet.ibm.com
Tue Nov 14 17:48:05 AEDT 2017

Cyril Bur <cyril.bur at au1.ibm.com> writes:
> This likely looks intentional and will do the correct thing.
> The correct behaviour does rely on the fact that skiboot has a custom
> assert() which will always generate code. 'Regular' assert() can be made
> to generate no code. If we were to do that with this code, the results
> would be, interesting!
> This patch will also keep Coverity happy which is nice.
> Fixes: CID 145242, 172044 and 172045
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> ---
>  hw/npu2.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

This patch merged as of 8ca2d61f3b4bac88d9d676bf305f1ee2956ce6ad
Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list