[Skiboot] [PATCH] p8-i2c: Don't write the watermark register at init

Stewart Smith stewart at linux.vnet.ibm.com
Tue Nov 14 17:47:03 AEDT 2017

Oliver O'Halloran <oohall at gmail.com> writes:
> On P9 the I2C master is shared with the OCC. Currently the watermark
> values are set once at init time which is bad for two reasons:
> a) We don't take the OCC master lock before setting it. Which
>    may cause issues if the OCC is currently using the master.
> b) The OCC might change the watermark levels and we need to reset
>    them.
> Change this so that we set the watermark value when a new transaction
> is started rather than at init time.
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>  hw/p8-i2c.c | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)


Merged to master as of d0f06269ed3cd3e09a9b04c5f70cb3d53a77a689

and seeing as we have possibly seen this be a problem, merged to 5.9.x
as of 0cc1fe4e23308fc4f4002c74b475475e96fedcb9.

Obviously, we should do some good testing.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list