[Skiboot] [PATCH 2/5] npu2: Refactor BAR setting code

Balbir Singh bsingharora at gmail.com
Tue Nov 14 11:23:22 AEDT 2017


On Mon, Nov 13, 2017 at 10:06 PM, Michael Neuling <mikey at neuling.org> wrote:
> This refactors the BAR setting code to make it clearer and handle a
> larger range of BAR addresses.
>
> No functional change.
>
> Signed-off-by: Michael Neuling <mikey at neuling.org>
> ---

We made this change for the reasons below and I think the changelog
should also state that
we now derive the chip and group information from the address as
opposed to p->chip_id
(which earlier had both) and we now have the flexibility of picking
select mem from the address
as well (which was assumed to be 0 earlier)

Reviewed-by: Balbir Singh <bsingharora at gmail.com>


More information about the Skiboot mailing list