[Skiboot] [PATCH v11 09/11] skiboot: Add opal call to enable/disable Nest IMC
Anju T Sudhakar
anju at linux.vnet.ibm.com
Fri May 12 16:26:33 AEST 2017
Thanks for the review comments.
On Friday 12 May 2017 07:50 AM, Stewart Smith wrote:
> Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
>> + * opal_imc_counters_init : This call initialize the IMC engine.
>> + *
>> + * This call is not being used in case of NEST IMC.
>> + * Additional arguments will be added to this call in the following patch.
>> + */
>> +static int64_t opal_imc_counters_init(uint32_t type)
>> + if (type == OPAL_IMC_COUNTERS_NEST)
>> + prerror("IMC: unknown operation for nest imc\n");
> I don't think you should prerror here, instead, just return
> OPAL_SUCCESS. Initing the nest counters is a no-op, so trying to init
> them will always succeed.
ok. will do.
Thanks and regards,
More information about the Skiboot