[Skiboot] [PATCH v11 09/11] skiboot: Add opal call to enable/disable Nest IMC
stewart at linux.vnet.ibm.com
Fri May 12 12:20:10 AEST 2017
Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
> + * opal_imc_counters_init : This call initialize the IMC engine.
> + *
> + * This call is not being used in case of NEST IMC.
> + * Additional arguments will be added to this call in the following patch.
> + */
> +static int64_t opal_imc_counters_init(uint32_t type)
> + if (type == OPAL_IMC_COUNTERS_NEST)
> + prerror("IMC: unknown operation for nest imc\n");
I don't think you should prerror here, instead, just return
OPAL_SUCCESS. Initing the nest counters is a no-op, so trying to init
them will always succeed.
OPAL Architect, IBM.
More information about the Skiboot