[Skiboot] [PATCH v11 05/11] dt: Add phandle fixup helpers
maddy at linux.vnet.ibm.com
Fri May 12 15:45:07 AEST 2017
On Friday 12 May 2017 09:06 AM, Stewart Smith wrote:
> Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
>> New subtree needs would have "phandle"
>> already assigned to some of it's nodes.
>> If this new substree is attached to main dt,
>> without fixing the phandles, would lead to
>> phandle duplicate errors.
>> Also, new subtree could have "properties"
>> refering to the phandle. So these "properties"
>> should also get updated accordingly when fixing
>> the "phandle".
>> New helper dt_adjust_subtree_phandle() added to
>> core/device.c to do both. It does phandle fixup
>> with a single pass through the subtree.
> Great, this looks good.
> Please add tests to core/test though, as there's no reason we can't
> verify this code in unit tests.
Yes. Will look into this.
More information about the Skiboot