[Skiboot] [PATCH v11 05/11] dt: Add phandle fixup helpers

Stewart Smith stewart at linux.vnet.ibm.com
Fri May 12 13:36:23 AEST 2017

Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
> New subtree needs would have "phandle"
> already assigned to some of it's nodes.
> If this new substree is attached to main dt,
> without fixing the phandles, would lead to
> phandle duplicate errors.
> Also, new subtree could have "properties"
> refering to the phandle. So these "properties"
> should also get updated accordingly when fixing
> the "phandle".
> New helper dt_adjust_subtree_phandle() added to
> core/device.c to do both. It does phandle fixup
> with a single pass through the subtree.

Great, this looks good.

Please add tests to core/test though, as there's no reason we can't
verify this code in unit tests.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list