[Skiboot] [PATCH 1/2] hmi: refactor malfunction alert handling
ppaidipe at linux.vnet.ibm.com
Wed Mar 22 17:11:53 AEDT 2017
On 2017-03-16 12:40, Stewart Smith wrote:
> Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
>> The logic in decode_malfunction() is rather tricky to follow. Refactor
>> code to make it easier to follow.
>> No functional change.
>> Cc: Russell Currey <ruscur at russell.cc>
>> Cc: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
>> Cc: Ryan Grimm <grimm at linux.vnet.ibm.com>
>> Cc: Frederic Barrat <fbarrat at linux.vnet.ibm.com>
>> Cc: Daniel Axtens <dja at axtens.net>
>> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
>> I'd appreciate review here, I hope I haven't introduced any unintended
>> changes, but I also don't think I fully understand the expected
>> I've given it some limited testing, it doesn't seem to break my CAPI
>> series which is good.
> so, I'm pretty sure it's correct from my cusorary view... and I hope
> that now that it's merged to master as of
> b2dc494a4950927cdda5f009e1a482aabcb25afa that when Pridhiviraj runs the
> full HMI test suite next, we check that we didn't accidentally break
> anything that we all missed :)
I ran full HMI test suite on both fsp and OpenPower BMC systems
with skiboot has at the level SkiBoot 246fb04.
All tests are worked fine.
More information about the Skiboot