[Skiboot] [PATCH 1/2] hmi: refactor malfunction alert handling

Stewart Smith stewart at linux.vnet.ibm.com
Thu Mar 16 18:10:27 AEDT 2017

Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
> The logic in decode_malfunction() is rather tricky to follow. Refactor the
> code to make it easier to follow.
> No functional change.
> Cc: Russell Currey <ruscur at russell.cc>
> Cc: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> Cc: Ryan Grimm <grimm at linux.vnet.ibm.com>
> Cc: Frederic Barrat <fbarrat at linux.vnet.ibm.com>
> Cc: Daniel Axtens <dja at axtens.net>
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> ---
> I'd appreciate review here, I hope I haven't introduced any unintended
> changes, but I also don't think I fully understand the expected behaviour.
> I've given it some limited testing, it doesn't seem to break my CAPI kexec
> series which is good.

so, I'm pretty sure it's correct from my cusorary view... and I hope
that now that it's merged to master as of
b2dc494a4950927cdda5f009e1a482aabcb25afa that when Pridhiviraj runs the
full HMI test suite next, we check that we didn't accidentally break
anything that we all missed :)

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list