[Skiboot] [PATCH V3 2/2] platforms/zz: Initialize PRD in skiboot

Ananth N Mavinakayanahalli ananth at linux.vnet.ibm.com
Mon Mar 13 14:55:20 AEDT 2017


On Sat, Mar 11, 2017 at 10:57:46PM +0530, Vasant Hegde wrote:
> On 02/24/2017 04:00 PM, Ananth N Mavinakayanahalli wrote:
> >... since PRD runs in host userspace on P9 FSP based systems.
> >
> >Signed-off-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> >---
> >  hw/prd.c               |   10 +++-------
> >  platforms/ibm-fsp/zz.c |    3 +++
> >  2 files changed, 6 insertions(+), 7 deletions(-)
> >
> 
> .../...
> 
> 
> 
> >+	/* All P9 machines, even the FSP based ones run PRD in host userspace */
> >+	queue_prd_msg = queue_prd_msg_hbrt;
> >+	opal_register(OPAL_PRD_MSG, opal_prd_msg, 1);
> >
> >  	prd_node = dt_new(opal_node, "diagnostics");
> >  	dt_add_property_strings(prd_node, "compatible", "ibm,opal-prd");
> >diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c
> >index 89d87b4..5c0b3b1 100644
> >--- a/platforms/ibm-fsp/zz.c
> >+++ b/platforms/ibm-fsp/zz.c
> >@@ -29,6 +29,9 @@
> >
> >  static bool zz_probe(void)
> >  {
> >+	/* PRD runs in host userspace in P9 */
> >+	prd_init();
> >+
> 
> At this stage we are not sure that its zz platform. Hence I think we
> should move this code inside below if condition..
> 
>   if (platform == zz ) {
>   	  prd_init();
> 	return true;

We need to initialize PRD for all P9 platforms, so, maybe ok. I still
need to work on these patches once the i2c stuff goes in.



More information about the Skiboot mailing list