[Skiboot] [PATCH V3 2/2] platforms/zz: Initialize PRD in skiboot

[Vasant Hegde]

On 02/24/2017 04:00 PM, Ananth N Mavinakayanahalli wrote:
> ... since PRD runs in host userspace on P9 FSP based systems.
>
> Signed-off-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> ---
>   hw/prd.c               |   10 +++-------
>   platforms/ibm-fsp/zz.c |    3 +++
>   2 files changed, 6 insertions(+), 7 deletions(-)
>

.../...



> +	/* All P9 machines, even the FSP based ones run PRD in host userspace */
> +	queue_prd_msg = queue_prd_msg_hbrt;
> +	opal_register(OPAL_PRD_MSG, opal_prd_msg, 1);
>
>   	prd_node = dt_new(opal_node, "diagnostics");
>   	dt_add_property_strings(prd_node, "compatible", "ibm,opal-prd");
> diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c
> index 89d87b4..5c0b3b1 100644
> --- a/platforms/ibm-fsp/zz.c
> +++ b/platforms/ibm-fsp/zz.c
> @@ -29,6 +29,9 @@
>
>   static bool zz_probe(void)
>   {
> +	/* PRD runs in host userspace in P9 */
> +	prd_init();
> +

At this stage we are not sure that its zz platform. Hence I think we should move 
this code inside below if condition..

   if (platform == zz ) {
   	  prd_init();
	return true;
}

-Vasant


>   	/* FIXME: make this neater when the dust settles */
>   	if (dt_node_is_compatible(dt_root, "ibm,zz-1s2u") ||
>   	    dt_node_is_compatible(dt_root, "ibm,zz-1s4u") ||
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
>